Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla_conifgure.py: remove "experimental" option #485

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

yaronkaikov
Copy link
Collaborator

@yaronkaikov yaronkaikov commented Oct 1, 2023

Following the changes done in scylladb/scylladb#15233 . we need also remove the Experimental options in the machine-image

Closes: #484

fruch
fruch previously approved these changes Oct 1, 2023
Copy link
Collaborator

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch
Copy link
Collaborator

fruch commented Oct 1, 2023

@yaronkaikov

I would recommend taking it out of the docs as well

I.e. in readme, and I'm not sure where it's also documented, @annastuchlik might know

Following the changes done in
scylladb/scylladb#15233 . we need also remove
the `Experimental` options in machine-image

Closes: scylladb#484
@yaronkaikov
Copy link
Collaborator Author

@yaronkaikov

I would recommend taking it out of the docs as well

I.e. in readme, and I'm not sure where it's also documented, @annastuchlik might know

Removed also from README.md

@yaronkaikov yaronkaikov requested a review from fruch October 1, 2023 05:37
@yaronkaikov
Copy link
Collaborator Author

@yaronkaikov yaronkaikov merged commit daf190d into scylladb:next Oct 1, 2023
1 check passed
@yaronkaikov yaronkaikov deleted the remove-exper branch October 1, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scylla.yaml gets updated with the 'experimental': False config option which was removed from Scylla
2 participants