Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to the getting-started page #480

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

benipeled
Copy link
Contributor

The previous links /getting-started-google and /getting-started-azure didn't exist
Ideally, we should refer to [0] but it's an OS page and I don't
want to add OS vs. Enterprise condition so for now let's go without a direct link

This PR also contains the following two minor changes

[0] https://opensource.docs.scylladb.com/master/getting-started/cloud-instance-recommendations

@benipeled benipeled requested review from syuu1228 and a team September 20, 2023 10:03
@benipeled
Copy link
Contributor Author

Verified with https://jenkins.scylladb.com/job/scylla-master/job/releng-testing/job/next-machine-image/191/

GCP e2-micro (dev instance)

image

GCP c3-standard-4 (no auto-optimized instance)

image

syuu1228
syuu1228 previously approved these changes Sep 20, 2023
Copy link
Contributor

@syuu1228 syuu1228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benipeled
Copy link
Contributor Author

v2: remove the test_getting_started_url for all provides since it's not relevant anymore,
No need to add a test for the new msg

This commit resolves a broken link issue - the previous links
/getting-started-google and /getting-started-azure didn't exist

Ideally, we should refer to [0] but it's an OS page and I don't
want to add OS vs. Enterprise condition so for now let's go without a direct link

[0] https://opensource.docs.scylladb.com/master/getting-started/cloud-instance-recommendations
@benipeled benipeled merged commit 2de0695 into scylladb:next Sep 21, 2023
1 check passed
@benipeled benipeled deleted the fix_broken_link branch September 21, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants