Add missing i4g.4xlarge instnace type

[yaronkaikov]

Adding pre-configure io_setup values
Also since i4g doesn't support enhanced networking adding it to use ENA

[Annamikhlin]

Please check if you need to remove the i4g.large type, if it not should be supported

scylla-machine-image/common/scylla_cloud_io_setup

Lines 296 to 300 in a5c3707

	elif self.idata.instancetype == "i4g.large":
	self.disk_properties["read_iops"] = 34035
	self.disk_properties["read_bandwidth"] = 288471904
	self.disk_properties["write_iops"] = 27943
	self.disk_properties["write_bandwidth"] = 126763269

[yaronkaikov]

Please check if you need to remove the i4g.large type, if it not should be supported

scylla-machine-image/common/scylla_cloud_io_setup

Lines 296 to 300 in a5c3707

	elif self.idata.instancetype == "i4g.large":
	self.disk_properties["read_iops"] = 34035
	self.disk_properties["read_bandwidth"] = 288471904
	self.disk_properties["write_iops"] = 27943
	self.disk_properties["write_bandwidth"] = 126763269

We should support it as well. so keeping it

[Annamikhlin]

Please check if you need to remove the i4g.large type, if it not should be supported

scylla-machine-image/common/scylla_cloud_io_setup

Lines 296 to 300 in a5c3707

	elif self.idata.instancetype == "i4g.large":
	self.disk_properties["read_iops"] = 34035
	self.disk_properties["read_bandwidth"] = 288471904
	self.disk_properties["write_iops"] = 27943
	self.disk_properties["write_bandwidth"] = 126763269

We should support it as well. so keeping it

So we are supporting it but not testing it?

[Annamikhlin]

Please check if you need to remove the i4g.large type, if it not should be supported

scylla-machine-image/common/scylla_cloud_io_setup

Lines 296 to 300 in a5c3707

	elif self.idata.instancetype == "i4g.large":
	self.disk_properties["read_iops"] = 34035
	self.disk_properties["read_bandwidth"] = 288471904
	self.disk_properties["write_iops"] = 27943
	self.disk_properties["write_bandwidth"] = 126763269

We should support it as well. so keeping it

So we are supporting it but not testing it?

Ok, I see your answer in https://github.com/scylladb/scylla-pkg/pull/3556#discussion_r1309918566 :)

[Annamikhlin]

lgtm

[yaronkaikov]

Verified with https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/artifacts/job/artifacts-ami-arm-test/71/