scylla_cloud_io_setup: add preset configuration for all supported instance types on EC2 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tance types on EC2 Since we merged scylladb/scylladb@817f34d, we are missing preset configuration for c5d, m5d, m5ad, r5d, z1d. On such instance, our AMI causes error during startup (see scylladb/scylladb#9660). To fix the problem, we need to add preset configuration for these instance types.
|
This patch copied from scylladb/scylladb#9694, since we moved all cloud related code to this repository. |
yaronkaikov
approved these changes
Aug 28, 2023
|
@syuu1228 - at some point, we should move this code into a Python dictionary, no? |
benipeled
reviewed
Aug 28, 2023
| @@ -81,6 +81,172 @@ class aws_io_setup(cloud_io_setup): | |||
| self.disk_properties["read_bandwidth"] = 507338935 * nr_disks | |||
| self.disk_properties["write_iops"] = 57100 * nr_disks | |||
| self.disk_properties["write_bandwidth"] = 483141731 * nr_disks | |||
| elif idata.instance_class() in ("m5d", "r5d"): | |||
There was a problem hiding this comment.
@syuu1228 it should be self.idata.instance_class() - same for following refs ofc
|
@syuu1228 please make sure to verify every change in advanced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we merged scylladb/scylladb@817f34d, we are missing preset configuration for c5d, m5d, m5ad, r5d, z1d. On such instance, our AMI causes error during startup (see scylladb/scylladb#9660).
To fix the problem, we need to add preset configuration for these instance types.