Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/scylla_cloud.py: change retry logic of curl() to exponential backoff #445

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

syuu1228
Copy link
Contributor

Since IaaS services recommended to use exponential backoff logic when retries to call metadata services, we should do it in our scripts.

Referenced implementation in https://developers.google.com/analytics/devguides/reporting/core/v3/errors?hl=en

see https://docs.aws.amazon.com/general/latest/gr/api-retries.html

Related with scylladb/scylladb#13442

@syuu1228 syuu1228 requested a review from yaronkaikov May 1, 2023 09:37
Copy link
Collaborator

@yaronkaikov yaronkaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syuu1228 Please post the verification job for this change

@yaronkaikov
Copy link
Collaborator

@syuu1228 Please post the verification job for this change

Also please rebase

@syuu1228
Copy link
Contributor Author

@yaronkaikov got unrelated GCE build error during running test job:

 ERROR: (gcloud.compute.images.add-labels) HTTPError 400: Invalid value for field 'labels': ''. Label value 'debug-scylla-5.3.0-dev-x86_64-2023-05-08T21-39-11' violates format constraints. The value can only contain lowercase letters, numeric characters, underscores and dashes. The value can be at most 63 characters long. International characters are allowed.

https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/101/consoleFull

Maybe it's packer script bug on GCE build.

@yaronkaikov
Copy link
Collaborator

@yaronkaikov
Copy link
Collaborator

@yaronkaikov
Copy link
Collaborator

@syuu1228 I think I found a bug, you were right. i will try to figure it out

@yaronkaikov
Copy link
Collaborator

@syuu1228 I think I found a bug, you were right. i will try to figure it out

https://github.com/scylladb/scylla-pkg/pull/3406

@yaronkaikov
Copy link
Collaborator

@syuu1228 please rebase , my patch was merged

Since IaaS services recommended to use exponential backoff logic when
retries to call metadata services, we should do it in our scripts.

Referenced implementation in https://developers.google.com/analytics/devguides/reporting/core/v3/errors?hl=en

see https://docs.aws.amazon.com/general/latest/gr/api-retries.html

Related with scylladb/scylladb#13442
@yaronkaikov
Copy link
Collaborator

@yaronkaikov yaronkaikov merged commit 16b454e into scylladb:next Sep 19, 2023
1 check passed
@fgelcer
Copy link

fgelcer commented Sep 21, 2023

@yaronkaikov @syuu1228 , was this tested on GCE artifact image test? it seems to be failing, and @benipeled is stuck with this failures on master

@yaronkaikov
Copy link
Collaborator

@fgelcer
Copy link

fgelcer commented Sep 21, 2023

@benipeled
Copy link
Contributor

benipeled commented Sep 21, 2023

dequeued due to GCE/AZURE artifact failures
@syuu1228 please run full tests and investigate before re-merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants