-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/scylla_cloud.py: change retry logic of curl() to exponential backoff #445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syuu1228 Please post the verification job for this change
Also please rebase |
797221d
to
ceef017
Compare
@yaronkaikov got unrelated GCE build error during running test job:
Maybe it's packer script bug on GCE build. |
@syuu1228 wired, when running https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/103/ it passed successfully |
@syuu1228 I think I found a bug, you were right. i will try to figure it out |
|
@syuu1228 please rebase , my patch was merged |
ceef017
to
7c841fd
Compare
Since IaaS services recommended to use exponential backoff logic when retries to call metadata services, we should do it in our scripts. Referenced implementation in https://developers.google.com/analytics/devguides/reporting/core/v3/errors?hl=en see https://docs.aws.amazon.com/general/latest/gr/api-retries.html Related with scylladb/scylladb#13442
7c841fd
to
cbbbdd0
Compare
@yaronkaikov @syuu1228 , was this tested on GCE artifact image test? it seems to be failing, and @benipeled is stuck with this failures on master |
so perhaps it was a fluke... seeing the last 7 builds, only 1 passed |
dequeued due to GCE/AZURE artifact failures |
Since IaaS services recommended to use exponential backoff logic when retries to call metadata services, we should do it in our scripts.
Referenced implementation in https://developers.google.com/analytics/devguides/reporting/core/v3/errors?hl=en
see https://docs.aws.amazon.com/general/latest/gr/api-retries.html
Related with scylladb/scylladb#13442