Skip to content

Commit

Permalink
scylla_install_image:remove writeback_cache option
Browse files Browse the repository at this point in the history
Currently we're setting write_back_cache parameter in perftune for preinstalled Scylla images. This is bogus approach and should be disabled (see scylladb/seastar#1008). We shouldn't set this setting at all (this is 3-state option, where not-set is the recommended one).

Closes: scylladb/scylla-pkg#3099
  • Loading branch information
yaronkaikov committed Nov 14, 2023
1 parent 61e6b5e commit 2e7ab63
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions packer/scylla_install_image
Original file line number Diff line number Diff line change
Expand Up @@ -122,17 +122,14 @@ if __name__ == '__main__':
with open('/etc/chrony/sources.d/ntp-pool.sources', 'w') as f:
f.write('pool time.aws.com iburst\n')

sysconfig_opt = ''
kernel_opt = ''
grub_variable = 'GRUB_CMDLINE_LINUX_DEFAULT'
elif args.target_cloud == 'gce':
# align with other clouds image
run('apt-get purge -y rsyslog', shell=True, check=True)
sysconfig_opt = '--disable-writeback-cache'
kernel_opt = ''
grub_variable = 'GRUB_CMDLINE_LINUX_DEFAULT'
elif args.target_cloud == 'azure':
sysconfig_opt = '--disable-writeback-cache'
kernel_opt = ' rootdelay=300'
grub_variable = 'GRUB_CMDLINE_LINUX'

Expand All @@ -146,7 +143,7 @@ if __name__ == '__main__':
# so we want to enable it here
run('/opt/scylladb/scripts/scylla_cpuscaling_setup --force', shell=True, check=True)

run(f'/opt/scylladb/scripts/scylla_sysconfig_setup --set-clocksource {sysconfig_opt}', shell=True, check=True)
run(f'/opt/scylladb/scripts/scylla_sysconfig_setup --set-clocksource', shell=True, check=True)
if args.target_cloud == 'aws' or args.target_cloud == 'gce':
run(f'/opt/scylladb/scripts/scylla_swap_setup --swap-size-bytes {half_of_diskfree()} --swap-directory /', shell=True, check=True)
run('/opt/scylladb/scripts/scylla_coredump_setup', shell=True, check=True)
Expand Down

0 comments on commit 2e7ab63

Please sign in to comment.