scylla_node: populate env variable when running scylla-sstable #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if scylla is built in a dtest environment, and the shared libraries which it is linked against cannot be found in the testbed's default ld.so.conf paths, the tests which run scylla-sstable would fail. so, in this change. let's apply the `self._launch_env` when running scylla-sstable as well. previously, these env variables are only applied when launching scylla as a daemon. Signed-off-by: Kefu Chai <[email protected]>
so we don't need to check for its existence. simpler this way. Signed-off-by: Kefu Chai <[email protected]>
this change should not make difference. as we generally do not reuse the same instance of ScyllaNode for launching multiple instances of daemon, and the mutations applies to self._launch_env does not vary. but this change should reflect the design better, as `ScyllaNode.start()` should not mutate `self._launch_env`, which is used as a template based on which each call of `start()` can customize it based on the other another env variable. Signed-off-by: Kefu Chai <[email protected]>
|
tested using $ scripts/dbuild_collect_so.sh ~/dev/scylladb/build/cmake/scylla /tmp/dynamic_libs_for_dtest
$ SCYLLA_DBUILD_SO_DIR=/tmp/dynamic_libs_for_dtest JAVA_HOME=/usr/lib/jvm/jre-11 pytest --cassandra-dir $HOME/dev/scylladb/build/cmake scylla_sstable_test.py::TestScyllaSstableDumpData::test_scylla_sstable_basicnot really a dbuild build. but i also verified by checking the env variables manually. |
bhalevy
approved these changes
Aug 29, 2023
|
https://github.com/scylladb/scylla-ccm/actions/runs/6011490212/job/16304966887?pr=501#step:6:627 i am not sure why s-c failed to connect to scylla .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if scylla is built in a dtest environment, and the shared libraries
which it is linked against cannot be found in the testbed's default ld.so.conf
paths, the tests which run scylla-sstable would fail.
so, in this change. let's apply the
self._launch_envwhenrunning scylla-sstable as well. previously, these env variables
are only applied when launching scylla as a daemon.