ccmlib/node: capture the output of sstable2json command in logging file #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jul 28, 2023
tchaikov
reviewed
Jul 28, 2023
fruch
changed the title
run_sstable2jsonAfter recent changes to scylla, we fount that: * this call was failing silently * was printing to stdout, and not into logging exmple of such failure, that some test failed to notice: ``` [2023-07-26T06:42:39.223Z] Exception in thread "main" java.lang.NumberFormatException: For input string: "3g7z_0in1_5tmap2bezca73ozy4m" [2023-07-26T06:42:39.224Z] at java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) [2023-07-26T06:42:39.224Z] at java.base/java.lang.Integer.parseInt(Integer.java:652) [2023-07-26T06:42:39.224Z] at java.base/java.lang.Integer.parseInt(Integer.java:770) [2023-07-26T06:42:39.224Z] at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:280) [2023-07-26T06:42:39.224Z] at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:228) [2023-07-26T06:42:39.224Z] at org.apache.cassandra.io.sstable.Descriptor.fromFilename(Descriptor.java:217) [2023-07-26T06:42:39.224Z] at org.apache.cassandra.tools.SSTableExport.run(SSTableExport.java:188) [2023-07-26T06:42:39.224Z] at com.scylladb.tools.SSTableExport.main(SSTableExport.java:44) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent changes to scylla, we fount that:
exmple of such failure, that some test failed to notice: