Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetVolumeStats Node capability #50

Merged
merged 2 commits into from
May 20, 2024
Merged

Add GetVolumeStats Node capability #50

merged 2 commits into from
May 20, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented May 13, 2024 •
edited
Loading

GetVolumeStats returns useful statistics about particular volume managed by the driver.
These statistics are visible as kubelet metrics.

Fixes #46

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 13, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2024
@rzetelskik
Copy link
Member

Shouldn't we have an e2e for this? Or is that covered by the upstream suites somehow?

tnozicka
tnozicka reviewed May 14, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is neat but needs an e2e test

pkg/driver/volume/volumemanager.go Outdated Show resolved Hide resolved
@scylla-operator-bot scylla-operator-bot bot added area/dependency Issues or PRs related to dependency changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2024
@zimnx
Copy link
Collaborator Author

zimnx commented May 14, 2024

Added e2e.

rzetelskik
rzetelskik reviewed May 14, 2024
View reviewed changes
test/e2e/set/localdriver/metrics.go Outdated Show resolved Hide resolved
test/e2e/set/localdriver/metrics.go Outdated Show resolved Hide resolved
@zimnx zimnx force-pushed the volume-stats branch 2 times, most recently from 47ad8bd to 15d9cb6 Compare May 14, 2024 12:14
@zimnx
Copy link
Collaborator Author

zimnx commented May 14, 2024

Flake - #49 (comment)

/retest

@zimnx zimnx requested review from tnozicka and rzetelskik May 15, 2024 14:08
rzetelskik
rzetelskik previously approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

tnozicka
tnozicka previously approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
lgtm, modulo the nit

test/e2e/set/localdriver/metrics.go Outdated Show resolved Hide resolved
zimnx added 2 commits May 20, 2024 09:00
@zimnx
Add GetVolumeStats Node capability
fc4a773 
GetVolumeStats returns useful statistics about particular volume managed by the
driver.
These statistics are visible as kubelet metrics.
@zimnx
Update autogenerated
9979792
@zimnx zimnx dismissed stale reviews from tnozicka and rzetelskik via 9979792 May 20, 2024 07:00
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx zimnx requested a review from tnozicka May 20, 2024 07:00
tnozicka
tnozicka reviewed May 20, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks!

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit a8fe9ff into scylladb:master May 20, 2024
8 of 9 checks passed
@zimnx zimnx deleted the volume-stats branch June 10, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@rzetelskik rzetelskik rzetelskik left review comments

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PV space usage metrics missing for scylla storage class
3 participants
@zimnx @rzetelskik @tnozicka