-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(graphs): Mark dependency changes #502
base: master
Are you sure you want to change the base?
improvement(graphs): Mark dependency changes #502
Conversation
3f468b3
to
4f32a30
Compare
can we add the the full scylla release as well ? |
We can. See also that kernel changes almost every week, I wonder if we shouldn't mark only big changes like major version updates only (I mean still change will be shown, but point won't be marked). |
before I want to notice the change, we want to see them. one more thing, not for this PR, we should be able to change the x axis to something else like driver version, or just plain data of the run, cause we don't have version change or date in the drivers CI (at least not yet, we didn't thought of it yet) |
Summarizing:
Generally, SUT is detected automatically based on which dependency changes the most often. If driver version/build date will be changing the most often then it becomes the SUT. This feature is used e.g. in SM tests. We can adjust it in followup issues if we need something else. |
not sure automatic would fit the best, consider a case we run CI with multiple release of scylla, let say OSS and enterprise ? |
package name for both is |
in driver CI, we care to see the driver version change / commit, not necessarily scylla, in my example both driver, and scylla might be changing across time |
I doubt in testing performance while changing both dependencies at the same pace, anyway, we can adjust to whatever we need later. |
In performance tests it's important to note changes of dependencies, like kernel, drivers, stress tools and SUT version. This commit changes the way point is displayed: when there's package change (except SUT change) then the point gets a white background. Hovering over the point shows tooltip with all packages changes (including SUT). Tooltip position was adjusted to be show above the point so mouse is not covering text. closes: scylladb#490
4f32a30
to
5fe45ee
Compare
@fruch I adjusted the code, please see PR description to see the changes. |
In performance tests it's important to note changes of dependencies,
like kernel, drivers, stress tools and SUT version.
This commit changes the way point is displayed:
when there's package change (except SUT change) then the point gets
a white background.
Hovering over the point shows tooltip with all packages changes
(including SUT).
Tooltip position was adjusted to be show above the point so mouse is not
covering text.
closes: #490