Add subscription ID recognition to tungstenite and ws-rpc client #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
changed the title
masapr
approved these changes
Nov 7, 2023
| @@ -134,9 +134,25 @@ fn subscribe_to_server( | |||
| // Subscribe to server | |||
| socket.send(Message::Text(json_req))?; | |||
|
|
|||
| // Read the first message response - must be the subscription id. | |||
| let msg = read_until_text_message(&mut socket)?; | |||
| let value: Value = serde_json::from_str(&msg)?; | |||
There was a problem hiding this comment.
As far as I understand, all the following logic is analyzing a string. I would put this logic into its own function and write a test for each flow through. Then you know, that it's doing what you expect.
There was a problem hiding this comment.
I agree, unit testing does make sense here. But not just here, but also in the ws_client and other functions of this client. Would you agree to do that in a separate issue and PR?
There was a problem hiding this comment.
I would add tests for new logic from this PR in this PR. For adding tests to existing code, I would create a new issue.
There was a problem hiding this comment.
Added issue: #663, commit adding unit tests for changed code is incoming.
masapr
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ws-rpc and tungstenite clients with the following features:
closes #626