wip: l1 block hashes poc #1016
Draft
wip: l1 block hashes poc #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-trifonov
force-pushed
the
LimeChain/block-hashes-poc-2
branch
from
64f4cdd
to
24f9020
Compare
vladimir-trifonov
force-pushed
the
LimeChain/block-hashes-poc-2
branch
from
33b2481
to
49ecf53
Compare
…pliedL1BlockInBlock to return uint64 instead of uint256
reo101
force-pushed
the
LimeChain/block-hashes-poc-2
branch
from
b38c73b
to
7fafc28
Compare
zimpha
reviewed
Dec 12, 2023
|
|
||
| import {L1Blocks} from "../../src/L2/L1Blocks.sol"; | ||
|
|
||
| contract DeployL2L1BlocksContract is Script { |
There was a problem hiding this comment.
Since we need a hardfork to add this change, I think it's better to make it a predployed contract.
| * @return hash_ The keccak hash of all blockhashes in the provided range. | ||
| */ | ||
| function blockRangeHash(uint256 _from, uint256 _to) external view returns (bytes32 hash_) { | ||
| require(_to >= _from, "Incorrect from/to range"); |
There was a problem hiding this comment.
It is better to use custom error here.
|
|
||
| for (uint256 i = _from; i <= _to; i++) { | ||
| bytes32 blockHash = blockhash(i); | ||
| require(blockHash != 0, "Blockhash not available"); |
| // stack too deep | ||
| struct ChunkResult { | ||
| // _totalNumL1MessagesInChunk The total number of L1 messages popped in current chunk | ||
| uint256 _totalNumL1MessagesInChunk; |
There was a problem hiding this comment.
remove the bai in the variable name.
| BatchHeaderV0Codec.storeParentBatchHash(batchPtr, _parentBatchHash); | ||
| BatchHeaderV0Codec.storeSkippedBitmap(batchPtr, _skippedL1MessageBitmap); | ||
| BatchHeaderV0Codec.storeLastAppliedL1Block( |
There was a problem hiding this comment.
since we change the structure of BatchHeader, it is better to use another version.
| @@ -165,13 +190,13 @@ contract ScrollChain is OwnableUpgradeable, PausableUpgradeable, IScrollChain { | |||
| uint8 _version, | |||
| bytes calldata _parentBatchHeader, | |||
| bytes[] memory _chunks, | |||
| bytes calldata _skippedL1MessageBitmap | |||
| bytes calldata _skippedL1MessageBitmap, | |||
| uint64 _prevLastAppliedL1Block | |||
There was a problem hiding this comment.
What is the first value of _prevLastAppliedL1Block? And except the first one, all _prevLastAppliedL1Block can be found in the _parentBatchHeader, right?
| uint64 lastAppliedL1Block_ = lastAppliedL1Block; | ||
|
|
||
| /// @dev It handles the case where the block is in the future. | ||
| require(_number <= lastAppliedL1Block_, "L1Blocks: hash number out of bounds"); |
vladimir-trifonov
force-pushed
the
LimeChain/block-hashes-poc-2
branch
from
2585426
to
ee021f7
Compare
vladimir-trifonov
force-pushed
the
LimeChain/block-hashes-poc-2
branch
from
ee021f7
to
72fe2d2
Compare
…pliedL1BlockNumber as previous
…and blockRangeHash
…lock hashes specific fields add missing chunk setters
This reverts commit 82ef045.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Updating scroll monorepo to support l1 block hashes POC.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?