-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checkquery.py #64
Conversation
Changes made on the docstrings
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
Hey @Jk40git. I see that there's still some confusion here. The goal os this is not to have the same documentation string for all of the functions. The document string is for the arguments of the function, so we just need to reformat it and put the arguments of the function in the right place. I'll annotate the code a bit to explain what I'm talking about. |
src/scribe_data/checkquery.py
Outdated
|
||
Returns: | ||
str: the SPARQL query. | ||
The 'target' value given the passed arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want this here to be the same as it was before, but with a different format for the Returns:
. So ideally:
Returns
--------
str : the SPARQL query.
src/scribe_data/checkquery.py
Outdated
query (QueryFile): the query that failed. | ||
Parameters | ||
----------- | ||
source_value : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need message
and query
, the arguments of the function.
src/scribe_data/checkquery.py
Outdated
bool: True if connectivity established. False otherwise. | ||
Parameters | ||
----------- | ||
source_value : str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need url
and timeout
.
src/scribe_data/checkquery.py
Outdated
|
||
Returns | ||
-------- | ||
The 'target' value given the passed arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this to be bool : True if connectivity established. False otherwise.
.
src/scribe_data/checkquery.py
Outdated
|
||
Returns | ||
-------- | ||
The 'target' value given the passed arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need SPARQLWrapper : the context.
as that's the return value for this function.
Please check the edits I have just made |
Changes made in the docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more edits this time around, @Jk40git, but generally ok. Many of the parameter descriptions needed to be on a new line, and there we're some minor things like the dashes not being the same length as Parameters
and Returns.
@andrewtavis they are already on new lines or what do you mean please (the indentation)? |
Changes made on the docstrings
Contributor checklist
Description
Related issue