Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Czech verbs query #251

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

OkpePhillips
Copy link
Contributor

Contributor checklist


Description

The changes relate to expanding the verb queries for the Czech language to retrieve various forms of verbs from Wikidata. These queries are based on the verb forms available on Wikidata for the Czech language. Among the forms of verbs that the queries retrieve are:

  • Present Transgressive
  • Future Tense
  • Past Participle
  • Indicative Present Tense forms which include:
    • First Person Singular
    • Second Person Singular
    • Third Person Singular
    • First Person Plural
    • Second Person Plural
    • Third Person Plural
  • Indicative Preterite forms which include
    • First Person Singular
    • Second Person Singular
    • Third Person Singular
    • First Person Plural
    • Second Person Plural
    • Third Person Plural

The queries were tested using Wikidata query service and the output was without errors. These changes were based on the query written for the French language, with modifications to suit the grammatical features available for Czech verbs in Wikidata

Related issue

Copy link

github-actions bot commented Oct 5, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Data repo
  • The linting and formatting workflow within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review October 5, 2024 18:43
@andrewtavis
Copy link
Member

Hey @OkpePhillips 👋 Can you remove the changes to the Urdu language files in this PR so it's just the changes for Czech?

@OkpePhillips
Copy link
Contributor Author

Hi @andrewtavis, I have removed it.
Thank you for pointing it out.

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 7, 2024
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some expanding on the queries you sent along, @OkpePhillips, just to make sure that we're getting as many forms back as possible. We are getting some duplicates, but that's actually because there are duplicate forms in Wikidata. These will be removed eventually 😊

Thanks so much!

@andrewtavis andrewtavis merged commit 781f3c1 into scribe-org:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants