feat(3193): Add upstream remote trigger's pipeline name data into wor…

…kflow graph node as displayName [2] (#628)
screwdriver-cd · Sep 12, 2024 · 152c985 · 152c985
1 parent b0062ef
commit 152c985
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/pipeline.js b/lib/pipeline.js
@@ -1136,7 +1136,10 @@ class PipelineModel extends BaseModel {
                             const externalJob = externalWorkflow.nodes.find(n => n.name === externalJobName);
 
                             if (externalJob) {
+                                const { name, branch } = externalPipeline.scmRepo;
+
                                 node.id = externalJob.id;
+                                node.displayName = `${name}#${branch}:${externalJob.name}`;
                             } else {
                                 logger.error(
                                     `pipelineId:${externalPipelineId}: workflow has no job:${externalJobName}.`

diff --git a/test/lib/pipeline.test.js b/test/lib/pipeline.test.js
@@ -915,6 +915,10 @@ describe('Pipeline Model', () => {
             jobFactoryMock.create.withArgs(externalMock).resolves(externalModelMock);
             pipelineFactoryMock.get.resolves({
                 id: testId,
+                scmRepo: {
+                    branch: 'branch',
+                    name: 'org/repo'
+                },
                 update: sinon.stub().resolves(null),
                 remove: sinon.stub().resolves(null),
                 workflowGraph: { nodes: [{ name: '~pr' }, { name: '~commit' }, { name: 'main', id: 3 }] }
@@ -928,7 +932,7 @@ describe('Pipeline Model', () => {
                         { name: '~commit' },
                         { name: 'main', id: 1 },
                         { name: 'publish', id: 2 },
-                        { name: 'sd@123:main', id: 3 }
+                        { name: 'sd@123:main', displayName: 'org/repo#branch:main', id: 3 }
                     ],
                     edges: [
                         { src: '~pr', dest: 'main' },