Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to browser using CDP #227

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Connect to browser using CDP #227

merged 5 commits into from
Sep 4, 2023

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Sep 3, 2023

Closes #207

Tasks:

  • Implementation
  • Tests
  • Docs

This change only covers BrowserType.connect_over_cdp, it does not cover BrowserType.connect.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #227 (4a615ae) into main (f1004bd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          392       410   +18     
=========================================
+ Hits           392       410   +18     
Files Changed Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta marked this pull request as ready for review September 3, 2023 20:59
Copy link
Contributor

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@elacuesta elacuesta merged commit 10d330e into main Sep 4, 2023
17 checks passed
@elacuesta elacuesta deleted the connect-cdp branch September 4, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote chrome support
2 participants