Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test refactoring #223

Merged
merged 9 commits into from
Aug 16, 2023
Merged

Test refactoring #223

merged 9 commits into from
Aug 16, 2023

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Aug 16, 2023

  1. Updated tests to use the most recent versions of pytest plugins (previously not working with pytest-asyncio>=0.11)
  2. Split asyncio/twisted tests, they don't play well together
  3. Bump minimum Python version to 3.8, to use unittest.IsolatedAsyncioTestCase (py37 is EOL anyway)
  4. Pinned playwright==1.36.0 in tests, playwright==1.37.0 fails for some reason

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #223 (f280f4f) into main (1c3f425) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          388       388           
=========================================
  Hits           388       388           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta marked this pull request as ready for review August 16, 2023 02:49
@elacuesta elacuesta merged commit e0f3b61 into main Aug 16, 2023
17 checks passed
@elacuesta elacuesta deleted the test-refactoring branch August 16, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant