Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad page init callback code #222

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

elacuesta
Copy link
Member

#205 did not remove this block of code as it should have.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #222 (1b84033) into main (e0f3b61) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          388       381    -7     
=========================================
- Hits           388       381    -7     
Files Changed Coverage Δ
scrapy_playwright/handler.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elacuesta elacuesta merged commit 63c1fe9 into main Aug 17, 2023
17 checks passed
@elacuesta elacuesta deleted the fix-page-init-callback branch August 17, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant