Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass spider argument to _create_browser_context #212

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

elacuesta
Copy link
Member

Closes #211

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #212 (e3d7c4c) into main (78282b5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          362       362           
=========================================
  Hits           362       362           
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lishukan
Copy link

Cool, bro . I originally wanted to submit my PR after dinner . You're too fast

@elacuesta elacuesta merged commit 229442c into main Jul 21, 2023
19 checks passed
@elacuesta elacuesta deleted the pass-spider-argument branch July 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused 'spider' parameter in '_create_browser_context' method
2 participants