Set exc_info=True for warning log records (#219)

scrapy-plugins · Aug 7, 2023 · f5d7fc2 · f5d7fc2
1 parent 72060d2
commit f5d7fc2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/scrapy_playwright/handler.py b/scrapy_playwright/handler.py
@@ -231,6 +231,7 @@ async def _create_page(self, request: Request, spider: Spider) -> Page:
                         "scrapy_request_method": request.method,
                         "exception": ex,
                     },
+                    exc_info=True,
                 )
 
         page.on("close", self._make_close_page_callback(context_name))
@@ -318,6 +319,7 @@ async def _download_request(self, request: Request, spider: Spider) -> Response:
                         "scrapy_request_method": request.method,
                         "exception": ex,
                     },
+                    exc_info=True,
                 )
                 await page.close()
                 self.stats.inc_value("playwright/page_count/closed")
@@ -410,6 +412,7 @@ async def _apply_page_methods(self, page: Page, request: Request, spider: Spider
                             "scrapy_request_method": request.method,
                             "exception": ex,
                         },
+                        exc_info=True,
                     )
                 else:
                     pm.result = await _maybe_await(method(*pm.args, **pm.kwargs))
@@ -560,6 +563,7 @@ async def _request_handler(route: Route, playwright_request: PlaywrightRequest)
                             "playwright_request_method": playwright_request.method,
                             "exception": ex,
                         },
+                        exc_info=True,
                     )
                 else:
                     raise
@@ -591,6 +595,7 @@ def _attach_page_event_handlers(
                         "scrapy_request_method": request.method,
                         "exception": ex,
                     },
+                    exc_info=True,
                 )
 
 

diff --git a/tests/test_playwright_requests.py b/tests/test_playwright_requests.py
@@ -182,6 +182,7 @@ async def test_route_continue_exception(self, logger):
                     "playwright_request_method": playwright_request.method,
                     "exception": ex,
                 },
+                exc_info=True,
             )
 
             # unknown errors, re-raise