Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop six requirement #438

Merged
merged 4 commits into from
Jan 17, 2024
Merged

drop six requirement #438

merged 4 commits into from
Jan 17, 2024

Conversation

branchvincent
Copy link
Contributor

I noticed six is still required/used even though only 3.6+ is supported

  • First commit is all from pyupgrade: pipx run pyupgrade --py36-plus $(git ls-files '*.py')
  • Second commit is manual fixes, replacing the remaining uses of six and updating requirements

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (03c7993) 89.45% compared to head (e44b6ee) 89.44%.

Files Patch % Lines
shub/utils.py 80.00% 3 Missing ⚠️
shub/compat.py 60.00% 2 Missing ⚠️
shub/copy_eggs.py 33.33% 2 Missing ⚠️
shub/config.py 88.88% 1 Missing ⚠️
shub/exceptions.py 50.00% 1 Missing ⚠️
shub/schedule.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   89.45%   89.44%   -0.02%     
==========================================
  Files          34       34              
  Lines        2438     2407      -31     
==========================================
- Hits         2181     2153      -28     
+ Misses        257      254       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

requirements.in Outdated Show resolved Hide resolved
shub/image/deploy.py Outdated Show resolved Hide resolved
shub/image/test.py Outdated Show resolved Hide resolved
shub/image/test.py Outdated Show resolved Hide resolved
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@branchvincent
Copy link
Contributor Author

btw, any interest in raising the minimum python to 3.8 (since older versions are EOL)?

@wRAR
Copy link
Member

wRAR commented Jan 8, 2024

Yeah, I don't think it's useful to keep support for pre-3.8.

shub/image/run/wrapper.py Outdated Show resolved Hide resolved
@branchvincent
Copy link
Contributor Author

Rebased to resolve conflicts after #434

@Gallaecio Gallaecio merged commit d8d471c into scrapinghub:master Jan 17, 2024
31 of 33 checks passed
@branchvincent branchvincent deleted the drop-six branch January 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants