Allow beams to do energy leeching #6377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baezon
added
enhancement
Goober5000
reviewed
Oct 3, 2024
| @@ -2721,16 +2714,19 @@ static void ship_do_healing(object* ship_objp, object* other_obj, vec3d* hitpos, | |||
| } | |||
|
|
|||
| // if the hitting object is a weapon, maybe do some fun stuff here | |||
There was a problem hiding this comment.
If you changed the other comment, you should change this one too IMO.
Goober5000
removed
the
Waiting for Stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered having shockwaves do this too, but having "esuck" missiles suddenly start draining double the amount is probably not a good idea... so a problem for later.
Additionally, this removes the
Beams_use_damage_factorscheck fromshiphit_get_damage_weapon, the purpose of that function is to return the wip_index of the provided object, not to withhold it based on a specific usage. All locations in the code where this would be relevant already check this flag, or have been made to do so by this PR (indeed some unrelated feature, like "vampiric" have been inadvertently trapped behind this flag as a result).