Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to the FSO electrical arc system #6347

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Enhancements to the FSO electrical arc system #6347

wants to merge 6 commits into from

Commits on Oct 7, 2024

  1. electrical arc upgrade, stage 1: refactor data structures

    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a74849b View commit details
    Browse the repository at this point in the history

  2. fix scope of ship arc sound generation 

    The code for generating spark sounds was incorrectly copied from debris to ships, dating all the way back to retail.  The sound should be played once per generation event, not once for every electrical arc active on the ship.  This fixes a bug that caused overlapping electrical arc sounds.
    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    76f9328 View commit details
    Browse the repository at this point in the history

  3. rename debris spark timestamps, per Asteroth

    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    84f263a View commit details
    Browse the repository at this point in the history

  4. electrical arc upgrade, stage 2: make arrays dynamic

    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cca46ab View commit details
    Browse the repository at this point in the history

  5. electrical arc upgrade, stage 3: add support for customizing segment … 

    …depth and using persistent arc points
    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6e48b2e View commit details
    Browse the repository at this point in the history

  6. electrical arc upgrade, stage 4: add a new ModifyElectricArcPoints fu… 

    …nction with a handy valueToVec3d utility function
    @Goober5000
    Goober5000 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fdc9c7c View commit details
    Browse the repository at this point in the history