fix macOS build packaging issues #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
notimaginative
commented
Sep 23, 2023
notimaginative
commented
- handle double archiving of macOS builds so they'll work properly with Knossos
- fix issue where only a single configuration was included in the package (Release or FastDebug, not both)
- handle double archiving of macOS builds so they'll work properly with Knossos - fix issue where only a single configuration was included in the package (Release or FastDebug, not both)
notimaginative
added
ci
|
If there is a better way to do this please let me know. Be nice to see this fixed before the next stable release. |
|
Are there any issues that this PR addresses? Would be good to link/mention them here so they get closed properly. Were you able to test the build chain on your fork? |
|
No open issues on this as far as I'm aware. I've mentioned the problem several times on discord but there really just aren't enough macOS users around to complain about it. And this has NOT been tested. The resulting build would have to be pushed to nebula to know for sure if it's all fixed. Any new issue introduced here should be limited to macOS builds, but they're almost useless without these fixes anyway. |
Goober5000
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.