Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starfield animation handling #5582

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

TRBlount
Copy link
Contributor

@TRBlount TRBlount commented Sep 1, 2023

This fixes the formula (Which has been incorrect for quite some time) used to get the next frame of an animation used in a starfield and extends a previous change to apply to all bitmap animation types.

@TRBlount TRBlount added this to the Release 23.2 milestone Sep 1, 2023
@wookieejedi wookieejedi added cleanup A modification or rewrite of code to make it more understandable or easier to maintain. graphics A feature or issue related to graphics (2d and 3d) labels Sep 2, 2023
Copy link
Member

@Baezon Baezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should mention what is the specific error being corrected here?

code/starfield/starfield.cpp Outdated Show resolved Hide resolved
@Goober5000 Goober5000 merged commit 41af098 into scp-fs2open:master Sep 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup A modification or rewrite of code to make it more understandable or easier to maintain. graphics A feature or issue related to graphics (2d and 3d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants