Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyPI Support #34

Open
wants to merge 100 commits into
base: master
Choose a base branch
from
Open

Conversation

adam-grant-hendry
Copy link

This commit adds pyembree as a PyPI package so users may pip install it. This also resolves #23 .

1. Copy `Embree 2.17.7 x64-bit` DLLs to `pyembree`, headers to
   `pyembree/embree2`, and static libs to `pyembree/embree2/lib`

2. Update `setup.py` to include static libs in `Extension` modules
   list and add DLLs to package data

3. Add cython preprocessor directive to each `*.pyx` and `*.pxd` file
   to use the `c++` language

4. Change relative imports to absolute in `*.pyx` and `*.pxd` files

5. Add `MANIFEST.in` to include necessary data in package
The `pyproject.toml` can store the package `version`. Furthermore,
the command `poetry version` bumps the `version` in the
`pyproject.toml` file.
Also add `black` and `isort` as dev-dependencies. `black` respects
`isort` directives in `vscode` when sort imports on save is set.
@adam-grant-hendry
Copy link
Author

@scopatz Please kindly review this PR and let me know if you accept. This adds PyPI support.

@Hafplo
Copy link

Hafplo commented Aug 15, 2022

@scopatz please approve this PR and merge it to master.
It is extremely helpful

@adam-grant-hendry
Copy link
Author

@scopatz please approve this PR and merge it to master. It is extremely helpful

@Hafplo Even if he did, at this point I am now the owner of the PyPI branch for pyembree. You can pip install it now for 3.8. Some of his previous tests are failing. I believe this is going to become a forked repo that I will maintain from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install without conda
2 participants