Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct unit formatting #1035

Conversation

matthewfeickert
Copy link
Collaborator

@matthewfeickert matthewfeickert commented Oct 30, 2024

The 'GeV' should be rendered as text in mathrm, not in math text, like it is elsewhere in the paper

The resulting collisions are recorded with building-sized particle detectors positioned around the LHC's $27~\mathrm{km}$ ring that are designed to measure subatomic particle properties.

This was an author mistake by me caught only while reviewing the render for Issue #1033 and #1034. Apologies for this, as I should have been more careful in the review!

f792cb1 This PR
image image

* The 'GeV' should be rendered as text in mathrm, not in math text.
Copy link

github-actions bot commented Oct 30, 2024

Curvenote Preview

📭 No submissions available to inspect.

@matthewfeickert
Copy link
Collaborator Author

Curvenote Preview

📭 No submissions available to inspect.

CI is failing (as expected) as the API token has expired.

@matthewfeickert matthewfeickert requested a review from a team October 30, 2024 00:48
@matthewfeickert matthewfeickert self-assigned this Oct 30, 2024
rowanc1 added a commit that referenced this pull request Oct 30, 2024
@rowanc1
Copy link
Contributor

rowanc1 commented Oct 30, 2024

Picking this up in another incoming PR!

@rowanc1 rowanc1 closed this Oct 30, 2024
@matthewfeickert
Copy link
Collaborator Author

Resolved by #1036

rowanc1 added a commit that referenced this pull request Oct 30, 2024
@matthewfeickert matthewfeickert deleted the fix/correct-unit-formatting branch October 30, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants