-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: [Draft] Adapt the split and cross strategies to quantile regression class #304
Draft
thibaultcordier
wants to merge
14
commits into
scikit-learn-contrib:master
Choose a base branch
from
thibaultcordier:feature-split-cross-cqr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ENH: [Draft] Adapt the split and cross strategies to quantile regression class #304
thibaultcordier
wants to merge
14
commits into
scikit-learn-contrib:master
from
thibaultcordier:feature-split-cross-cqr
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MAPIE into feature-split-cross-cqr
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 3474 3399 -75
Branches 360 367 +7
=========================================
- Hits 3474 3399 -75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Valentin-Laurent
changed the title
ENH: Adapt the split and cross strategies to quantile regression class
ENH: [Draft] Adapt the split and cross strategies to quantile regression class
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, conformalized quantile regression has only been implemented with the split-conformal strategy. It would be worth extending it to cross-CQR with the
cv
argument. This PR proposes to adapt the quantile regression class for split and cross conformal strategies by adding to theinit
method thecv
parameter so that it is comparable to the regression class.Fixes #200
Type of change
Please remove options that are irrelevant.
How Has This Been Tested?
Checklist
make lint
make type-check
make tests
make coverage
make doc