Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial-buildorder argument to the build-tree #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ammernico
Copy link
Collaborator

  • Introduced a new command-line argument --serial-buildorder that outputs the tree-of package in a serial build order.
  • The --serial-buildorder argument conflicts with the existing --dot argument for now. Showing the serial build order in the dot format would not bring any benefits.
  • Ensured cyclic dependency detection and error handling during topological sorting.

Copy link
Member

@primeos-work primeos-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM but a few details aren't right yet.

src/cli.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Show resolved Hide resolved
src/commands/tree_of.rs Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
src/commands/tree_of.rs Outdated Show resolved Hide resolved
@primeos-work primeos-work linked an issue Sep 16, 2024 that may be closed by this pull request
@ammernico ammernico marked this pull request as ready for review September 18, 2024 12:21
- Introduced a new command-line argument `--serial-buildorder` that
  outputs the tree-of package in a serial build order.
- The `--serial-buildorder` argument conflicts with the existing `--dot`
  argument for now. Showing the serial build order in the dot format
  would not bring any benefits.
- Ensured cyclic dependency detection and error handling during
  topological sorting.

Fixes science-computing#379

Signed-off-by: Nico Steinle <[email protected]>
@christophprokop
Copy link
Collaborator

tested successfully :) thx!

@christophprokop christophprokop added the prerelease PRs which are merged to staging branch but not in main/master label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prerelease PRs which are merged to staging branch but not in main/master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

butido tree-of --serial-buildorder
3 participants