Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations triggered since twig 3.12.0 #591

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

deguif
Copy link
Contributor

@deguif deguif commented Sep 2, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes/no
Fixed tickets
License Apache2

Description

Avoid deprecations triggered by twig 3.12 while keeping backward compatibility

Here's the deprecations it fixes:

Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated.
Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\Filter\RawFilter" class is deprecated.

@deguif deguif changed the title fix: fix deprecations triggered since twig 3.12.0 Fix deprecations triggered since twig 3.12.0 Sep 2, 2024
@deguif
Copy link
Contributor Author

deguif commented Sep 6, 2024

@goetas do you think it can be merged soon?

@deguif
Copy link
Contributor Author

deguif commented Sep 23, 2024

Friendly ping @goetas , as we are waiting for this before upgrading twig to 3.12 and later.

@goetas goetas merged commit d1f7e18 into schmittjoh:master Sep 23, 2024
17 checks passed
@goetas
Copy link
Collaborator

goetas commented Sep 23, 2024

Sorry for the delay

@deguif
Copy link
Contributor Author

deguif commented Sep 23, 2024

Thanks @goetas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants