Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added '--add-description' option #459

Merged
merged 10 commits into from
Jul 26, 2024
Merged

Conversation

mistajase79
Copy link
Contributor

This new option will add the track description to an separate *.txt file (using the same filename as the music file).
Some music players will display this text whilst the track is playing - great for tracklists on DJ mixes and podcasts.

This new option will add the track description to a txt file (using the same filename as the music file).
Some music players will display this text whilst the track is playing - great for tracklists on DJ mixes and podcasts.
@authorisation
Copy link

Any progress on this getting merged?

@7x11x13
Copy link
Member

7x11x13 commented Jul 26, 2024

Question: why only create the description file if the length of the description is > 3? Why not if it is > 0?

@7x11x13
Copy link
Member

7x11x13 commented Jul 26, 2024

This is ready to be merged, when you answer my question above @mistajase79

@mistajase79
Copy link
Contributor Author

mistajase79 commented Jul 26, 2024

Question: why only create the description file if the length of the description is > 3? Why not if it is > 0?

Was only to prevent adding description files if only an emoji was used - technically it shouldn't really matter, more of an edge case... happy to set to zero

@7x11x13 7x11x13 merged commit 43890f9 into scdl-org:master Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants