Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go mod + instance volume size #106

Closed
wants to merge 6 commits into from
Closed

fix: go mod + instance volume size #106

wants to merge 6 commits into from

Conversation

QuentinBrosse
Copy link

DO NOT MERGE: This is a work in progress, this branch needs to be manually tested before a potential merge.

Work:

Example:

# Create an ubuntu-bionic DEV1-S
# It will throw an error because ubuntu bionic doesn’t have sudo installed by default
$ docker-machine create -d scaleway --scaleway-name="scw-machine-test-1" --scaleway-commercial-type="DEV1-S" --scaleway-image="f974feac-abae-4365-b988-8ec7d1cec10d" test1
[...]
Provisioning with ubuntu(systemd)...
Error creating machine: Error running provisioning: ssh command error:
command : sudo hostname test1 && echo "test1" | sudo tee /etc/hostname
err     : exit status 127
output  : bash: sudo: command not found

# We need to install it:
$ docker-machine ssh test1 apt install sudo
[...]

# Re-provisionning
$ docker-machine provision test1
[...]

# Done 🎉 

Todo:

Fix the sudo issue (firstly discovered here).

In the docker libmachine, the generic provisioner call sudo without checking if the command is installed before while Ubuntu Bionic doesn't have sudo by default anymore.

The UbuntuSystemdProvisioner seems to not be compatible with Ubuntu Bionic (the last tested version is 15.04).

I can see two solutions:

  • Fix the UbuntuSystemdProvisioner
  • Try to do it in our provider (even if it is not the right place IMO)

@QuentinBrosse
Copy link
Author

Continue the work in #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant