Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix settings to build with newer Java version #70

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

KodaiD
Copy link
Contributor

@KodaiD KodaiD commented Aug 13, 2024

Description

In PR 211, it was reported that some samples could not be built with newer Java versions. In this PR, I modify some build.gradle files to build all ScalarDB samples with Java 8, 11, 17.

Related issues and/or PRs

Changes made

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Copy link
Contributor

@kota2and3kan kota2and3kan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

FYI: I was able to build these three updated samples by using Java 17 in my local environment!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@KodaiD Do the other samples work with the newer Java versions? Or do we need to do something for them as well?

@KodaiD
Copy link
Contributor Author

KodaiD commented Aug 14, 2024

LGTM! Thank you!

@KodaiD Do the other samples work with the newer Java versions? Or do we need to do something for them as well?

@brfrn169 Thanks for reviewing this.
I've confirmed that all samples (except scalardb-analytics-postgresql-sample, scalardb-analytics-spark-sample, scalardb-cluster-standalone-mode, scalardb-kotlin-sample) can be built with Java 8, 11, 17.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 879baf1 into main Aug 15, 2024
@feeblefakie feeblefakie deleted the fix-settings-to-build-with-newer-java branch August 15, 2024 06:09
@KodaiD KodaiD mentioned this pull request Oct 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants