Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move addressbook and orders fixtures to protobufs since they are only used there #375

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Sep 15, 2023

...and decrease the coverage of Chimney test module

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d9558e7) 80.18% compared to head (b0b99c1) 80.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files         109      109           
  Lines        4133     4133           
  Branches      172      172           
=======================================
  Hits         3314     3314           
  Misses        819      819           
Files Changed Coverage Δ
...and/chimney/fixtures/addressbook/AddressBook.scala 1.42% <ø> (ø)
...la/io/scalaland/chimney/fixtures/order/order.scala 1.06% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit d53f562 into master Sep 15, 2023
21 checks passed
@MateuszKubuszok MateuszKubuszok deleted the protobuf-fixtures-in-pb-module branch September 15, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant