Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable -Xfatal-warnings #373

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Re-enable -Xfatal-warnings #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import commandmatrix.extra.*
lazy val isCI = sys.env.get("CI").contains("true")
ThisBuild / scalafmtOnCompile := !isCI

// publishSigned emits
// Could not find any member to link for "scala.None".
// and similar, and we cannot turn them off in any other way than by removing -Xfatal-warnings
// so at least we can remove them ONLY when building a release from a commit which already
// passed the tests.
lazy val isRelease = sys.env.get("RELEASE").contains("true")

// versions

val versions = new {
Expand Down Expand Up @@ -201,9 +208,8 @@ val publishSettings = Seq(
<url>http://github.com/MateuszKubuszok</url>
</developer>
</developers>
),
scalacOptions -= "-Xfatal-warnings"
)
)
) ++ (if (isRelease) Seq(scalacOptions -= "-Xfatal-warnings") else Seq.empty)

val mimaSettings = Seq(
mimaPreviousArtifacts := {
Expand Down
1 change: 0 additions & 1 deletion protobufs/src/test/scala/io/scalaland/chimney/PBTransformationSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import io.scalaland.chimney.dsl._
// format: on
import io.scalaland.chimney.examples.pb
import io.scalaland.chimney.fixtures.{addressbook, order}
import io.scalaland.chimney.{partial, ChimneySpec, PartialTransformer}

class PBTransformationSpec extends ChimneySpec {

Expand Down