Tighten closure extractor in TreeInfo #21621
Open
+54
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous extractor for closures matches also arbitrary blocks that ended in a (possible deeply nested) closure. This caused wrong use sets in scala#21620. The new definition is stricter. There is also a new blockEndingInclosure extractor that keeps the old behavior. Fixes scala#21620
dwijnand
reviewed
Sep 20, 2024
| @@ -814,17 +814,31 @@ trait TypedTreeInfo extends TreeInfo[Type] { self: Trees.Instance[Type] => | |||
| case _ => false | |||
| } | |||
|
|
|||
| /** An extractor for closures, either contained in a block or standalone. | |||
| /** An extractor for closures, possibly typed, and possibly including the | |||
| * definition of the ananonymous def. | |||
There was a problem hiding this comment.
... the definition of an anonymous def or the anonymous def?
There was a problem hiding this comment.
the def that corresponds to the closure node.
There was a problem hiding this comment.
Suggested change
| * definition of the ananonymous def. | |
| * definition of the anonymous def. |
dwijnand
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous extractor for closures matches also arbitrary blocks that ended in a (possible deeply nested) closure. This caused wrong use sets in #21620. The new definition is stricter. There is also a new blockEndingInclosure extractor that keeps the old behavior.
Fixes #21620