Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change the trigger to check the CLA" #20568

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Jun 14, 2024

Reverts #20567

It turns out to be a bad idea, PRs only keep the status of the jobs of the last commit. Therefore, we will always have a the CLA job that is not reported...

I've played around in a different repository to test which is best but this new trigger is very much useless in our use case.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.

@hamzaremmal hamzaremmal merged commit 2b49ac8 into main Jun 14, 2024
40 checks passed
@hamzaremmal hamzaremmal deleted the revert-20567-cla-trigger branch June 14, 2024 13:19
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants