-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the API name entry for nested classes #20279
Conversation
da05f1f
to
c5ca07d
Compare
Thanks for investigating this! I'll review soon |
Should this be backported to Scala 2? |
2.13 bridge should be ok hopefully. As far as I know, the extracted name hasn't changed on Zinc side in a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So the problem was the canonical name of Java static class:
package example;
class A {
static class B { }
}
The canonical name of B
should be example.A.B
and not example.A$.B
93db2f2
to
6759a8b
Compare
**Problem** Some build pipelining tests fail on the latest sbt RC. ``` Error: (sbt-test / scripted) Failed tests: Error: pipelining/Yjava-tasty-fromjavaobject Error: pipelining/Yjava-tasty-paths ``` This is likely caused by inconsistent capturing of APIs from Java sources in ExtractAPI vs AnalyzingJavaCompiler in Zinc. **Solution** This adjusts the API name entry for Java nested classes.
6759a8b
to
accf42d
Compare
Backports #20279 to the LTS branch. PR submitted by the release tooling.
Problem
#20157 demonstrated that some build pipelining tests fail on the latest sbt 1.10.0-RC2:
This is likely caused by inconsistent capturing of APIs from Java sources in ExtractAPI vs AnalyzingJavaCompiler in Zinc.
Solution
This adjusts the API name entry for Java nested classes.