Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish sbom along with other artifacts #57

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Jun 12, 2024

This produces artifact names consistent with the Maven plugin, e.g. pekko-actor_2.13-cylonedx.xml

Implements #54

I'd have liked to add a scripted test, but it seems scripted doesn't allow referring to '$HOME' or '~' for checking files have been created.

@raboof raboof force-pushed the publish-bom branch 2 times, most recently from 8069deb to 9cd991d Compare October 17, 2024 12:23
@mdedetrich
Copy link
Contributor

I think it makes sense to merge #63 before this PR so you can get all of the formatting updates as well

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after rebase from main

I'd have liked to add a scripted test, but it seems scripted
doesn't allow referring to '$HOME' or '~' for checking files
have been created.

This produces artifact names consistent with the Maven plugin,
e.g. `pekko-actor_2.13-cylonedx.xml`

Implements sbt#54
@raboof raboof merged commit da10d7d into sbt:main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants