Fix command-builder arg escape for ;

Issue #551

Also version bump for patch release

package.json

@@ -1,6 +1,6 @@
 {
   "name": "scanservjs",
-  "version": "2.25.1",
+  "version": "2.25.2",
   "description": "scanservjs is a simple web-based UI for SANE which allows you to share a scanner on a network without the need for drivers or complicated installation.",
   "scripts": {
     "clean": "rm -rf ./dist",

packages/client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scanservjs",
-  "version": "2.25.1",
+  "version": "2.25.2",
   "description": "scanservjs is a simple web-based UI for SANE which allows you to share a scanner on a network without the need for drivers or complicated installation.",
   "author": "Sam Strachan",
   "scripts": {

packages/server/package.json

@@ -1,6 +1,6 @@
 {
   "name": "scanservjs-api",
-  "version": "2.25.1",
+  "version": "2.25.2",
   "description": "scanservjs-api is a REST based API to control your scanner.",
   "scripts": {
     "lint": "gulp lint",

packages/server/src/classes/command-builder.js

@@ -18,7 +18,7 @@ module.exports = class CommandBuilder {
     if (typeof value === 'string') {
       if (value.includes('\'')) {
         throw Error('Argument must not contain single quote "\'"');
-      } else if (['$', ' ', '#', '\\'].some(c => value.includes(c))) {
+      } else if (['$', ' ', '#', '\\', ';'].some(c => value.includes(c))) {
         return `'${value}'`;
       }
     }

packages/server/test/command-builder.test.js

@@ -15,12 +15,18 @@ describe('CommandBuilder', () => {
       'echo \'hello world\'');
   });
 
-  it('command-arg2', async () => {
+  it('command-arg-hash', async () => {
     assert.strictEqual(
       new CommandBuilder('echo').arg('-n', 'hello#world').build(),
       'echo -n \'hello#world\'');
   });
 
+  it('command-arg-comma', async () => {
+    assert.strictEqual(
+      new CommandBuilder('echo').arg('-n', 'hello;world').build(),
+      'echo -n \'hello;world\'');
+  });
+
   it('command-security-1', async () => {
     assert.strictEqual(
       new CommandBuilder('echo').arg('-n', 'hello" && ls -al;# world').build(),