Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js and other packages #66

Closed
wants to merge 7 commits into from
Closed

Update Node.js and other packages #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
654f322
Use the context.sha for the base sha
cwbusacker Mar 21, 2024
ce1bd76
Chore: update @types/node, @actions/github, and octokit
cwbusacker Mar 21, 2024
3e18d94
Add an error message with context when sha is empty
cwbusacker Mar 21, 2024
a4d96b4
chore: use node20
cwbusacker Mar 21, 2024
af613c1
context.sha didn't work because it wasn't providing a commit that was…
cwbusacker Mar 21, 2024
c6bd7e9
Stringify the context if sha is empty string
cwbusacker Mar 21, 2024
b74e4d3
Don't use pull_request.head for she
cwbusacker Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ branding:
icon: cloud-lightning
color: blue
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@
"dependencies": {
"@actions/artifact": "^2.1.1",
"@actions/core": "^1.10.0",
"@actions/github": "^5.1.1",
"@actions/github": "^6.0.0",
"@actions/exec": "^1.1.1",
"@types/js-yaml": "^4.0.5",
"adm-zip": "^0.5.10",
"octokit": "^2.0.19",
"octokit": "^3.1.2",
"picomatch": "^2.3.1"
},
"devDependencies": {
"@types/adm-zip": "^0.5.0",
"@types/node": "^18.16.3",
"@types/node": "^20.11.30",
"@types/picomatch": "^2.3.0",
"@typescript-eslint/parser": "^7.0.0",
"@vercel/ncc": "^0.36.1",
Expand Down
7 changes: 6 additions & 1 deletion src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,14 @@ async function run(): Promise<void> {
repo: context.repo.repo ?? '',
owner: context.repo.owner ?? '',
issue_number: context.payload.number ?? 0,
sha: context.payload.after ?? ''
sha: context.payload.after || '',
})

if(github.CONFIG.sha === '')
{
console.error(`Error: Commit sha is an empty string. This action may not be supported in this context. Context: ${JSON.stringify(context)}`)
}

if (UPLOAD_KEY) {
const ARTIFACT_RETENTION_DAYS = getInput('ARTIFACT_RETENTION_DAYS')
? parseInt(getInput('RETENTION_DAYS'), 10)
Expand Down
Loading