Fix md.features and data.features comparison #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run UpdateSeuratObject on this dataset I got the following error message:
Error in !all.equal(target = md.features, current = data.features, check.attributes = FALSE) : invalid argument type
all.equal
returns true ifmd.features
anddata.features
are indeed identical. However in case where the two vectors differ it returns a character vector of length two describing the mismatch. For the RNA slot in the above dataset it returns:The proposed change simply replaces
all.equal()
withidentical()
which should be more suitable as it will simply determine if the two vectors are identical and returns a boolean which can then be used by the if statement.