Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix md.features and data.features comparison #210

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

neanderthalensis
Copy link

When trying to run UpdateSeuratObject on this dataset I got the following error message: Error in !all.equal(target = md.features, current = data.features, check.attributes = FALSE) : invalid argument type

all.equal returns true if md.features and data.features are indeed identical. However in case where the two vectors differ it returns a character vector of length two describing the mismatch. For the RNA slot in the above dataset it returns:

[1] "Lengths (463, 461) differ (string compare on first 461)"
[2] "8 string mismatches" 

The proposed change simply replaces all.equal() with identical() which should be more suitable as it will simply determine if the two vectors are identical and returns a boolean which can then be used by the if statement.

@neanderthalensis neanderthalensis changed the base branch from master to develop May 31, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant