Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sass-parser support for the @while rule #2410

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Add sass-parser support for the @while rule #2410

merged 6 commits into from
Oct 31, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 25, 2024

No description provided.

@nex3 nex3 requested a review from Goodwine October 25, 2024 01:19
Goodwine
Goodwine requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can run npm run fix to get rid of the reported issues. You may have to run it again if you submit after #2415

pkg/sass-parser/lib/src/statement/while-rule.test.ts Outdated Show resolved Hide resolved
pkg/sass-parser/lib/src/stringifier.ts Outdated Show resolved Hide resolved
@nex3 nex3 requested a review from Goodwine October 29, 2024 22:41
Goodwine
Goodwine approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I submitted the PR that updated gts, you should rerun npm run fix

@nex3 nex3 merged commit a9254df into main Oct 31, 2024
39 checks passed
@nex3 nex3 deleted the parser-while branch October 31, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @Goodwine