-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose calculations in JS API #1988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nex3 I'm getting a bunch of call stack errors, it sounds like I'm somehow messing up the methods and getters https://github.com/sass/dart-sass/actions/runs/5205889223/jobs/9391830839?pr=1988
Co-authored-by: Jonny Gerig Meyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nex3 I'm getting a bunch of call stack errors, it sounds like I'm somehow messing up the methods and getters https://github.com/sass/dart-sass/actions/runs/5205889223/jobs/9391830839?pr=1988
It's very frustrating that this doesn't actually include the stack trace! My suggestion would be to create a little test.js file that loads the compiled JS from build/npm
and directly invokes the functions that are overflowing, and see if that gives more clarity on what the actual recursive call stack is.
@nex3 I'm working on the changes to
It sounds like we need to modify if (result is Value) {
if (result is SassCalculation)
return SassCalculation._simplify(result);
return result;
} But |
@jerivas Since we don't want |
sass/sass#3622
sass/sass-spec#1918
sass/embedded-host-node#237