Skip to content

Commit

Permalink
Do not validate a CSS declaration if its key is interpolated (#2036)
Browse files Browse the repository at this point in the history
* Do not validate a CSS declaration if itss key is interpolated

* add changelog
  • Loading branch information
Goodwine authored Jul 14, 2023
1 parent 262961c commit fe7f9a1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
emitted in source order as much as possible, instead of always being emitted
after the CSS of all module dependencies.

* Fix a bug where an interpolation in a custom property name crashed if the file
was loaded by a `@use` nested in an `@import`.

### JavaScript API

* Produce a better error message when an environment that supports some Node.js
Expand Down
2 changes: 1 addition & 1 deletion lib/src/visitor/async_evaluate.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3034,7 +3034,7 @@ class _EvaluateVisitor

Future<void> visitCssDeclaration(CssDeclaration node) async {
_parent.addChild(ModifiableCssDeclaration(node.name, node.value, node.span,
parsedAsCustomProperty: node.isCustomProperty,
parsedAsCustomProperty: node.parsedAsCustomProperty,
valueSpanForMap: node.valueSpanForMap));
}

Expand Down
4 changes: 2 additions & 2 deletions lib/src/visitor/evaluate.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_evaluate.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 0f0705b9773f694816ebf00cc91f43146d8c46ab
// Checksum: 81aac8d1ac5bea43a019307cc5eb754610b0c6be
//
// ignore_for_file: unused_import

Expand Down Expand Up @@ -3009,7 +3009,7 @@ class _EvaluateVisitor

void visitCssDeclaration(CssDeclaration node) {
_parent.addChild(ModifiableCssDeclaration(node.name, node.value, node.span,
parsedAsCustomProperty: node.isCustomProperty,
parsedAsCustomProperty: node.parsedAsCustomProperty,
valueSpanForMap: node.valueSpanForMap));
}

Expand Down

0 comments on commit fe7f9a1

Please sign in to comment.