This repository has been archived by the owner on May 29, 2020. It is now read-only.
Pass timestamp option for svgo(node engine) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapegin
suggested changes
Mar 15, 2017
tasks/webfont.js
Outdated
| @@ -116,7 +116,8 @@ module.exports = function(grunt) { | |||
| cache: options.cache || path.join(__dirname, '..', '.cache'), | |||
| callback: options.callback, | |||
| customOutputs: options.customOutputs, | |||
| execMaxBuffer: options.execMaxBuffer || 1024 * 200 | |||
| execMaxBuffer: options.execMaxBuffer || 1024 * 200, | |||
| ts: (options.ts === 0) ? 0 : options.ts || Math.floor(Date.now() / 1000) | |||
There was a problem hiding this comment.
The name is far from clear. Could you add docs and tests too?
There was a problem hiding this comment.
Okay, I'll add docs and tests
|
This seems to solution to make woff binary to not differ from time to time. I thinks this is what I need to stop webpack from giving the font a different hash every time the font is generated. How is the status? |
sapegin
reviewed
May 24, 2017
| @@ -6,6 +6,8 @@ var path = require('path'); | |||
| var grunt = require('grunt'); | |||
| var parseXMLString = require('xml2js').parseString; | |||
| var wf = require('../tasks/util/util'); | |||
| var crypto = require('crypto'); | |||
| var Promise = require('promise'); | |||
There was a problem hiding this comment.
Promises are supported since Node 0.12, so you don’t need a polyfill.
|
|
||
| // If font created multiple times with same value as timestamp option | ||
| // then md5 of created files must be the same too | ||
| timestamp_same: function (test) { |
There was a problem hiding this comment.
Wouldn’t it be easier to compare file contents? ;-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.