added getNextCodepoint() fix; (#364)

added tests
sapegin · May 8, 2017 · 015ad38 · 015ad38
1 parent 36a5693
commit 015ad38
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 1 deletion.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -348,6 +348,16 @@ module.exports = function(grunt) {
 					stylesheets: ['css', 'scss', 'less']
 				}
 			},
+			filename_length: {
+				src: 'test/src_filename_length/*.svg',
+				dest: 'test/tmp/filename_length',
+				options: {
+					autoHint: false,
+					engine: 'node',
+					hashes: false,
+					types: 'woff'
+				}
+			},
 		},
 		nodeunit: {
 			all: ['test/webfont_test.js']

diff --git a/tasks/webfont.js b/tasks/webfont.js
@@ -622,7 +622,7 @@ module.exports = function(grunt) {
 		 * @return {Integer}
 		 */
 		function getNextCodepoint() {
-			while (_.includes(o.codepoints, currentCodepoint)) {
+			while (_.invert(o.codepoints).hasOwnProperty(currentCodepoint)) {
 				currentCodepoint++;
 			}
 			return currentCodepoint;

diff --git a/test/src_filename_length/length.svg b/test/src_filename_length/length.svg
diff --git a/test/webfont_test.js b/test/webfont_test.js
@@ -915,6 +915,20 @@ exports.webfont = {
 		// Files should render with custom context variables
 		test.ok(fs.existsSync('test/tmp/custom_output/context-test.html'));
 
+		test.done();
+	},
+
+	filename_length: function(test) {
+
+		// File should have been created.
+		test.ok(fs.existsSync('test/tmp/filename_length/icons.css'));
+
+		// File should have been created.
+		test.ok(fs.existsSync('test/tmp/filename_length/icons.woff'));
+
+		// File should have been created.
+		test.ok(fs.existsSync('test/tmp/filename_length/icons.html'));
+
 		test.done();
 	}