-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use slices instead of Vectors #48
base: main
Are you sure you want to change the base?
Conversation
How do I format it with the projects coding style? cargo fmt seems to use my own preset. |
I use the default configurarion, normally nothing special. Maybe you have a global configuration (in a parent directory) ? |
b7fd758
to
d474c10
Compare
I doubt the valgrind error is caused by my changes 🤔 |
You probably right, on my PC, the result is almost the same. |
Is something missing here? @sanpii |
I fixed the CI, can you base your PR on my I also tried to understand the complicated syntax for Maybe this form is clearer: let param_values = [Some(b"joe's place\0".as_ref())]; In any cases, a vector is useless here. |
Please rebase, don't merge. |
No description provided.