Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slices instead of Vectors #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use slices instead of Vectors #48

wants to merge 3 commits into from

Conversation

nyovaya
Copy link

@nyovaya nyovaya commented Aug 17, 2024

No description provided.

@nyovaya
Copy link
Author

nyovaya commented Aug 17, 2024

How do I format it with the projects coding style? cargo fmt seems to use my own preset.

examples/testlibpq3.rs Outdated Show resolved Hide resolved
@sanpii
Copy link
Owner

sanpii commented Aug 17, 2024

How do I format it with the projects coding style? cargo fmt seems to use my own preset.

I use the default configurarion, normally nothing special. Maybe you have a global configuration (in a parent directory) ?

@nyovaya
Copy link
Author

nyovaya commented Aug 17, 2024

I doubt the valgrind error is caused by my changes 🤔

@sanpii
Copy link
Owner

sanpii commented Aug 18, 2024

I doubt the valgrind error is caused by my changes 🤔

You probably right, on my PC, the result is almost the same.

@nyovaya nyovaya requested a review from sanpii August 18, 2024 13:39
@nyovaya
Copy link
Author

nyovaya commented Aug 20, 2024

Is something missing here? @sanpii

@sanpii
Copy link
Owner

sanpii commented Aug 24, 2024

I fixed the CI, can you base your PR on my main branch?

I also tried to understand the complicated syntax for param_values in examples/testlibpq3.rs.

Maybe this form is clearer:

let param_values = [Some(b"joe's place\0".as_ref())];

In any cases, a vector is useless here.

@sanpii
Copy link
Owner

sanpii commented Aug 24, 2024

Please rebase, don't merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants