Merge develop into master #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also updates the corresponding unit test in JsonApi.spec.js to reflect the changes made to the find function.
This commit refactors the find function in the JsonApi module to extract the includes from the found data. The extractIncludes function is introduced to handle the extraction of includes from relationships. The includes are then flattened and duplicates are removed using the Set data structure. This change improves the efficiency and readability of the code. Related issue: N/A
…a single record does not return data as an array.
…ships and extract includes
Fixed dodgy tests.
Fixed issue with find where it was producing empty includes. Fixed follow on issue where there was a maximum call stack exceeded and so introduced depth for extracting includes.
…data. Remove unused data files.
- Refactored ONTPoolCreate and ONTSampleIndex tests to use factories for data. - Removed OntPool json file. - Refactored getters.spec.js to improve readability and maintainability. - Refactored getters.spec.js to use factories for OntPlate and OntPool data. - Updated ontAndTags.csv with additional data. - Updated JsonApi.spec.js to remove unnecessary code. - Updated ont_pools_view.cy.js to use factories for OntPool and Printer data. - Updated ont_pool_edit.cy.js to use factories for OntPool data. - Updated ont_pool_create.cy.js to use factories for OntTagSet, Printer, and OntPlate data.
…arameters. Fixed e2e tests.
Y24-361 Sort By in Pacbio Libraries view, by id, descending by default
Y24-345 - Ont Pools store migration from axios to native fetch to reduce dependencies and increase maintainability.
…Y24-344-qc-result-upload-fetch-migration
…igration Y24-344 - QC Results Upload migration to fetch.
stevieing
approved these changes
Oct 22, 2024
SHIV5T3R
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version