-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-190-3: Support Limber with BulkTransfers on v2 API #4425
base: develop-Y24-190
Are you sure you want to change the base?
Y24-190-3: Support Limber with BulkTransfers on v2 API #4425
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-Y24-190 #4425 +/- ##
===================================================
- Coverage 86.47% 86.42% -0.05%
===================================================
Files 1394 1396 +2
Lines 29740 29752 +12
===================================================
- Hits 25717 25713 -4
- Misses 4023 4039 +16 ☔ View full report in Codecov by Sentry. |
…https://github.com/sanger/sequencescape into Y24-190-support-limber-with-bulk-transfers-on-v2-api
…transfers-on-v2-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, have given a once-over, but not thoroughly.
# BultTransfer.create!({ | ||
# BulkTransfer.create!({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well caught
…transfers-on-v2-api # Conflicts: # .rubocop_todo.yml
Closes #4244
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code