Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-190-3: Support Limber with BulkTransfers on v2 API #4425

Open
wants to merge 15 commits into
base: develop-Y24-190
Choose a base branch
from

Conversation

sdjmchattie
Copy link
Contributor

Closes #4244

Changes proposed in this pull request

  • Add the endpoint for BulkTransfers.
  • Add tests for the endpoint.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

@sdjmchattie sdjmchattie self-assigned this Oct 17, 2024
@sdjmchattie sdjmchattie marked this pull request as draft October 17, 2024 11:18
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.42%. Comparing base (ec83232) to head (0556504).

Files with missing lines Patch % Lines
lib/tasks/devour.rake 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           develop-Y24-190    #4425      +/-   ##
===================================================
- Coverage            86.47%   86.42%   -0.05%     
===================================================
  Files                 1394     1396       +2     
  Lines                29740    29752      +12     
===================================================
- Hits                 25717    25713       -4     
- Misses                4023     4039      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdjmchattie sdjmchattie marked this pull request as ready for review October 18, 2024 11:13
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have given a once-over, but not thoroughly.

# BultTransfer.create!({
# BulkTransfer.create!({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well caught

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants